Tor bridges preferences fix #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2022 11:38
…Tor. Previously they would be accessed too early when preferences had not yet been read from disk. Now we access them when Tor is started.
This is necessary because Tor settings are edited before the app has completed startup and normally persistence is prohibited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5937
Postpone accessing preferences BridgeAddressProvider until needed by Tor. Previously they would be accessed too early when preferences had not yet been read from disk. Now we access them when Tor is started.
Force persistence write when editing Tor Bridge settings. This is necessary because Tor settings are edited before the app has completed startup and normally persistence is prohibited.
With this change it is possible to use Tor bridges when Bisq refuses to start with the default settings. A button to edit the Tor settings is shown after the startup times-out allowing Tor bridges to be chosen and to restart Bisq with the new settings.
After choosing Tor bridges, the setting will be used at next startup: