Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording for Bsq swap cancellation popups & withdrawal prompt #5957

Merged
merged 1 commit into from Jan 10, 2022
Merged

Wording for Bsq swap cancellation popups & withdrawal prompt #5957

merged 1 commit into from Jan 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2022

Fixes #5956

  • This PR addresses two issues raised by Unnecessary popup after removing BSQ swap offer #5956
  • Additionally fixes a related issue when canceling a Bsq Swap from Market View it was mentioning losing 0.00 maker fee.
  • Additionally, when an offer being cancelled, refer to it as "this offer" instead of "that offer".

1

After cancelling a Bsq Swap do not show the "Withdraw to wallet" prompt as it is unnecessary.

2

Withdrawal prompt reworded to avoid confusion (click for details)

Pre
wording_change_normal_offer_pre

Post
wording_change_normal_offer_post

3

Bsq Swap canceled from Market View -> remove reference to maker fee. (click for details)

Pre
remove_no_fee_offer_pre

Post
remove_no_fee_offer_post

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.1 milestone Jan 10, 2022
@ripcurlx ripcurlx merged commit 96878e5 into bisq-network:master Jan 10, 2022
@ghost ghost mentioned this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary popup after removing BSQ swap offer
1 participant