Set gradle java src & target compat = VERSION_11 #5860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change sets java source and class generation version targets to 11. The Bisq distribution is built with JDK 11, but source target has remained at 1.10. Upgrading allows devs to use some Java syntax features available @SInCE 11, and it might help anyone building the src avoid confusion over which JDK they should use (minimum is JDK 11). See https://docs.gradle.org/current/userguide/java_plugin.html#sec:java-extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets java source and class generation version targets to 11. The Bisq distribution is built with JDK 11, but the build file's source target has remained at 1.10. Upgrading allows devs to use java syntax features and apis available
@since 11, and it might help anyone building the src avoid confusion over which JDK they should use: the minimum is JDK 11, but the oldsourceCompatibilitywas 1.10, implying JDK 10 might work.See https://docs.gradle.org/current/userguide/java_plugin.html#sec:java-extension