Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception in offer entry UI #5753

Merged
merged 1 commit into from Oct 14, 2021
Merged

Fix exception in offer entry UI #5753

merged 1 commit into from Oct 14, 2021
+2 −2

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2021

Fixes an exception in offer entry when fixed prices are used.

Steps to reproduce issue:

First, select the option of fixed price:

image

  • Click on create offer to Buy.
  • Select the Fixed Price option (per screenshot above).
  • Close the enter offer dialog. This saves the setting.
  • Again, click on create offer to Buy.
  • Enter 0.01 (for BTC amount), [TAB], 0, [TAB], 0, [TAB], [TAB].
  • Exception error popup message is shown.

image

image

ripcurlx
ripcurlx approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.7.5 milestone Oct 14, 2021
@ripcurlx ripcurlx merged commit c9a6407 into bisq-network:master Oct 14, 2021
@ghost ghost mentioned this pull request Oct 19, 2021
Closed
@ghost ghost deleted the fix_exception_enteroffer branch May 29, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.5
Development

Successfully merging this pull request may close these issues.
1 participant
@ripcurlx