Fix data handling if dao is deactivated #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are still received from seed nodes and processed but as the services for processing the payloads are not added the data is inefficiently processed. The getMap returned a flattened map of all maps in all services which can be quite large. We use now a filtered map with calling canHandle first. Also the put got optimized to indicate in the return value if there has been a service found to add the payload. If not we do not invoke the listeners and do not broadcast. To not request the DAO P2P data would be better but I don't see a easy way how to do that as the P2P network is not aware of the type of data. Some market interface could be used and a flag at the request to the seed node to indicate if those types should be included but that does feel too customized for a special use case. The DAO P2P data is not that big as well, so I think for now that fix should be good enough.
We write the value to the properties file not to the preferences as we need the value early at startup before the preferences are loaded.
Use appendOnlyDataStoreService.getMap(persistableNetworkPayload) instead.
Make it more clear that we expect only one matching service which can handle the payload.
|
Adjusted the DAO view in case DAO is deactivated. @m52go Could you have a look to the text? DAO view in case DAO is deactivated: Settings when DAO is deactivated. Shows activate toggle. Settings when DAO is activated. |
|
Suggestion: |
|
Tested DAO view is adjusted for Tested Tested Tested dao activation/deactivation from UI. OK Tested Tested we expect only one matching service which can handle the payload. OK Ran modified test cases / all passed. OK |
ripcurlx
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toggle for deactivating the DAO and fixes an issue with P2P data processing if DAO is deactivated.