Add hint to upgrade to tor v3

[ripcurlx]

If the node is in a state where an upgrade to a Tor v3 address can be done it displays a informational prompt.

@m52go ☝️ This needs some native speaker love.

I'll check this state on application start and when the last open trade is completed. I wanted to do this for closed disputes as well, but the data structure in place would force me to scatter check codes on multiple places which would make it burdensome to remove after the transition is complete.

To have a graceful upgrade proces nodes with a Tor v2 address won't be able to take offers anymore starting with August 15, 2020 (2 months before the Tor v2 support is dropped). Also their offers won't be visible to anyone else at that point.

I also added some unrelated checks to this upgrade process, that you can only reopen trades and disputes if you have the same local onion address to prevent communication issues that would go by without notice.

This fixes #5558.

[ripcurlx]

To test this on Regtest you have to modify the OfferRestrictions.REQUIRE_TOR_NODE_ADDRESS_V3_DATE and set --useLocalhostForP2P=false

[ripcurlx]

@pazza83 Does the timeline sounds reasonable to you?

[m52go]

Suggestion:

popup.info.torMigration.msg=Your Bisq node is currently using a Tor v2 address. Tor v2 is being deprecated soon \ [HYPERLINK:https://blog.torproject.org/v2-deprecation-timeline], and \
Bisq nodes with Tor v2 addresses will no longer be able to trade on August 15th, 2021.\n\n\
  Please switch your Bisq node to a Tor v3 address. It's quick and simple -- see details in this doc \
  [HYPERLINK:https://bisq.wiki/Changing_your_onion_address] or in this video [HYPERLINK:https://bitcointv.com/videos/watch/f96adc20-4092-4253-84c0-1b18088b4b95]. \n\n\
  Make sure to back up your data directory beforehand.

I think it makes sense to leave out some of the details since they're already mentioned in the link.

[sqrrm]

Some comments but looks mostly good. I haven't tested and looks somewhat annoying to test on regtest, have you tested it?

[ripcurlx]

Some comments but looks mostly good. I haven't tested and looks somewhat annoying to test on regtest, have you tested it?

Yes, I did test it on Regtest.

[sqrrm]

utACK

[Giszmo]

The hint is great but after going to backup, it's gone and I have a hard time finding the advertised video on how to switch to v3.

[m52go]

@Giszmo ah didn't think of that. Here are the links:

• https://bisq.wiki/Changing_your_onion_address
• https://bitcointv.com/videos/watch/f96adc20-4092-4253-84c0-1b18088b4b95

[Giszmo]

I found the links by searching for this PR ;D

Just wonder how non-developers are supposed to find them cause I took the non-developer route, first and googled for 10 minutes. The video did come up quickly but I had dismissed it, as it doesn't have "TORv3" in the title and was 45min long.

[m52go]

"Tor v3" is in the title on both YouTube and BitcoinTV but I guess it doesn't matter if neither shows up.

Maybe we should put the links and some copy on the backup screen that the primary call-to-action (green button) leads to in the next release? This might allow for reducing text in the modal and putting details in a less ephemeral place users can refer back to (i.e. the backup screen).

[ripcurlx]

True - I missed that people might not click on the links in the popups first before doing the backup.