Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually create BSQ outputs #5534

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented May 26, 2021

Avoid relying on bitcoinj completeTx for creation of BSQ change
outputs as dust BSQ would be used for mining fee, thus burning
the BSQ.

Fixes #5533

Avoid relying on bitcoinj completeTx for creation of BSQ change
outputs as dust BSQ would be used for mining fee, thus burning
the BSQ.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested on Regtest BSQ and non-BSQ (BTC) withdrawal from BSQ wallet with manual and automatic inputs. Does work as expected now 👍

@ripcurlx ripcurlx merged commit 670ba87 into bisq-network:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.6.5] Change output below dust limit is burned when custom inputs are used
2 participants