Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jcenter repository #5497

Merged
merged 1 commit into from
May 17, 2021

Conversation

cd2357
Copy link
Contributor

@cd2357 cd2357 commented May 16, 2021

Replace the jcenter repo with mavenCentral and jitpack.

One of the dependencies had a slightly different name in jcenter compared to jitpack (com.github.jengelman.gradle.plugins:shadow vs com.github.johnrengelman:shadow), so that was renamed as well.

Fixes #5496

Replace the jcenter repo with mavenCentral and jitpack.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - as the lib hash hasn't been changed, so it should still be exact the same lib.

@ripcurlx ripcurlx added this to the v1.6.5 milestone May 17, 2021
@ripcurlx ripcurlx merged commit 9d6236c into bisq-network:master May 17, 2021
@cd2357
Copy link
Contributor Author

cd2357 commented May 17, 2021

I didn't find the shadow dependency hash in gradle-witness.gradle, maybe because its not a dependency per se but just a plugin used during building.

As a test, I updated the version to 6.0.0 in

classpath 'com.github.johnrengelman:shadow:5.2.0'
and gradle-witness didn't complain.

So the hash isn't checked.

I did find a way to preserve the plugin name (by adding another repo to the list, PR incoming).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove JCenter dependencies from build
2 participants