Fix mac jar hash #5487
Merged
Fix mac jar hash #5487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SHA256 checksum for each generated binary.
Copy the deterministic, signed jar to the binaries folder only after it has been processed. Once copied, it will be checksum-ed in the last packaging step.
|
Discussion ongoing about how to best solve this. The |
|
As discussed with @ripcurlx this might be worth trying out for the mac build, even though that jar won't be reproducible on other platforms due to signing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the deterministic, signed jar to the binaries folder only after it has been processed. Once copied there, it will be checksum-ed in the last packaging step and the resulting hash will be ready for publishing with the release.
This solves the issue in v1.6.3 and v1.6.4 where the jar was checksum-ed and copied to the binaries folder before being signed and processed (dylib processing, macOS-specific). This resulting checksum would therefore not match anymore with the hash of the signed jar contained in the
dmg.