Fix the formula used to calculate BSQ amount needed to avoid dust #5475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am confused is 5.46 not the dust limit?
|
|
5.46 is the dust limit, so each output need to be at least 546 sat. If you have 7 BSQ (700 sat) you can burn 1.54 BSQ and have a change output of 5.46 since the burnt BSQ is used to pay the mining fee which is not an output, just the remainder of all the inputs minus outputs. Please let me know if this didn't help explain the situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formula used to calculate the BSQ needed to avoid dust was incorrect.
For example, this was before:
The BSQ amount needed should be 8, not 13. Now it is fixed.