Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter banned seednodes with wrong format #5469

Merged

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented May 5, 2021

This prevents incorrect formatted banned seednodes in bisq.properties file to block Bisq from starting.

It will only log an error and filter all banned seednodes that are correctly formatted.
I checked banned BTC nodes and banned price relay nodes and those are handled gracefully already.

@ripcurlx ripcurlx requested a review from sqrrm May 5, 2021 08:23
@ripcurlx ripcurlx added this to the v1.6.4 milestone May 5, 2021
@ripcurlx ripcurlx force-pushed the filterBannedSeednodesWithWrongFormat branch from bf756b4 to 35ede06 Compare May 5, 2021 09:22
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 2205726 into bisq-network:master May 5, 2021
@ripcurlx ripcurlx deleted the filterBannedSeednodesWithWrongFormat branch July 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants