Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string when creating a new offer #5451

Merged
merged 4 commits into from
May 7, 2021

Conversation

BtcContributor
Copy link
Contributor

@BtcContributor BtcContributor commented Apr 30, 2021

Now it is similar to the message provided when taking a new offer.

See:

takeOffer.takeOfferFundWalletInfo.msg=You need to deposit {0} for taking this offer.\n\nThe amount is the sum of:\n{1}- Your security deposit: {2}\n- Trading fee: {3}\n- Total mining fees: {4}\n\nYou can choose between two options when funding your trade:\n- Use your Bisq wallet (convenient, but transactions may be linkable) OR\n- Transfer from an external wallet (potentially more private)\n\nYou will see all funding options and details after closing this popup.

@ripcurlx
Copy link
Contributor

ripcurlx commented May 4, 2021

@m52go Could you please ACK this change? Thanks!

Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
@BtcContributor
Copy link
Contributor Author

@m52go so should we also change this

takeOffer.takeOfferFundWalletInfo.msg=You need to deposit {0} for taking this offer.\n\nThe amount is the sum of:\n{1}- Your security deposit: {2}\n- Trading fee: {3}\n- Total mining fees: {4}\n\nYou can choose between two options when funding your trade:\n- Use your Bisq wallet (convenient, but transactions may be linkable) OR\n- Transfer from an external wallet (potentially more private)\n\nYou will see all funding options and details after closing this popup.
?

Like that: You need to deposit {0} to take this offer

@m52go
Copy link
Contributor

m52go commented May 6, 2021

@m52go so should we also change this

Yes, that would be better.

@m52go
Copy link
Contributor

m52go commented May 6, 2021

ACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit eb9bce3 into bisq-network:master May 7, 2021
@ripcurlx ripcurlx added this to the v1.6.5 milestone May 7, 2021
@BtcContributor BtcContributor deleted the fixstringmakingoffer branch May 7, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants