Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DAO data store for v1.6.3 #5449

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Apr 29, 2021

This is a new updated DAO data store that is synced from last release running a full node with the BSQ SegWit PR applied.
Light node in light mode and full node in dark mode. There is a conflict on both nodes in the blind vote state with one of the seednodes because of a difference in the number of votes, which relies on the fact that two votes were mined too late and were counted as invalid.

Bildschirmfoto 2021-04-29 um 20 18 24

Bildschirmfoto 2021-04-29 um 20 18 29

Bildschirmfoto 2021-04-29 um 20 18 42

Bildschirmfoto 2021-04-29 um 20 18 47

Bildschirmfoto 2021-04-29 um 20 19 06

Bildschirmfoto 2021-04-29 um 20 19 10

@boring-cyborg boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Apr 29, 2021
@ripcurlx ripcurlx changed the title <!-- - make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md) - make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues) - pick a descriptive title - provide some meaningful PR description below - create the PR - in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation. - After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required". --> Update DAO data store for v1.6.3 Apr 29, 2021
@ripcurlx ripcurlx changed the base branch from master to release/v1.6.3 April 29, 2021 18:23
@ripcurlx
Copy link
Contributor Author

@chimp1984 Please have a look at it as well if this state is fine from your point of view. Thanks!

@chimp1984
Copy link
Contributor

Looks ok to me. Maybe u can cross check the DAO state hash with http://46.101.179.224:8080/

@ripcurlx
Copy link
Contributor Author

Looks ok to me. Maybe u can cross check the DAO state hash with http://46.101.179.224:8080/

The dao state hash seems to be different. Proposal and blind vote is the same.

@chimp1984
Copy link
Contributor

Looks ok to me. Maybe u can cross check the DAO state hash with http://46.101.179.224:8080/

The dao state hash seems to be different. Proposal and blind vote is the same.

Oh, I will cross check... Lets wait with release until its confirmed that its ok.

@chimp1984
Copy link
Contributor

I was running your branch and I get the same daostate hash:
DAO state block height: 681146
DAO state hash: f0ad4135c637196ebe9a240e4ae1e9799fc0cf93

You have to check if the block height is the same...

Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit e287fdd into bisq-network:release/v1.6.3 Apr 30, 2021
@ripcurlx ripcurlx deleted the release/v1.6.3 branch July 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants