Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassCastException in Portfolio History screen #5358

Merged
merged 1 commit into from Mar 26, 2021
Merged

Fix ClassCastException in Portfolio History screen #5358

merged 1 commit into from Mar 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 25, 2021

Exception in Portfolio History view because wasMyOffer(tradable) is being used to check if the list item is an offer or trade.


To reproduce the problem: your portfolio history contains a canceled offer that was made with a different onion address. This can be quite common if you have changed your onion address (see #5035 and #3995)

exception

Mar-25 17:29:39.270 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
Mar-25 17:29:39.270 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= bisq.core.offer.OpenOffer cannot be cast to bisq.core.trade.Trade 
Mar-25 17:29:39.270 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.ClassCastException 
Mar-25 17:29:39.272 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.ClassCastException: bisq.core.offer.OpenOffer cannot be cast to bisq.core.trade.Trade
    at bisq.desktop.main.portfolio.closedtrades.ClosedTradesViewModel.getTradeFee(ClosedTradesViewModel.java:177)
    at bisq.desktop.main.portfolio.closedtrades.ClosedTradesView$12$1.updateItem(ClosedTradesView.java:678)
    at bisq.desktop.main.portfolio.closedtrades.ClosedTradesView$12$1.updateItem(ClosedTradesView.java:674)
    at javafx.scene.control.TableCell.updateItem(TableCell.java:665)

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.6.0 milestone Mar 26, 2021
@ripcurlx ripcurlx merged commit c0cfd25 into bisq-network:master Mar 26, 2021
@ghost ghost deleted the fix_ClassCastException branch May 29, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant