Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pay from BSQ wallet button #5316

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Add pay from BSQ wallet button #5316

merged 1 commit into from
Mar 17, 2021

Conversation

chimp1984
Copy link
Contributor

Add button to buyers trade step 2 view in case of a BSQ trade to fill in the amount and address to the BSQ send view.

@chimp1984
Add button to buyers trade step 2 view in case of a BSQ
2702a7e 
trade to fill in the amount and address to the BSQ send view.
@chimp1984
Copy link
Contributor Author

Screenshot 2021-03-15 at 17 45 49

Screenshot 2021-03-15 at 17 45 54

@ripcurlx ripcurlx added this to the v1.6.0 milestone Mar 16, 2021
@ripcurlx
Copy link
Contributor

To me Pay from BSQ wallet sounds like it would automatically pay the BSQ from the BSQ wallet. Maybe it should be labeled Go to BSQ wallet?

@wallclockbuilder
Copy link
Contributor

Maybe a tooltip? Right next to the button.
[ PAY FROM BSQ WALLET ] ( i ) Fills out the address and amount. You have to press send to pay.

ripcurlx
ripcurlx approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - I missed that it pre-populates the input fields to send the BSQ, so it is not a simple go to wallet button. After thinking about it I think it is fine doing it like this, as even if a user thinks this will automatically send the BSQ will see that she is re-directed to the wallet for confirmation.

@ripcurlx
Copy link
Contributor

Maybe a tooltip? Right next to the button.
[ PAY FROM BSQ WALLET ] ( i ) Fills out the address and amount. You have to press send to pay.

Yes, maybe an info could improve this, but I don't think it is a showstopper for this PR.

@ripcurlx ripcurlx merged commit 16230c7 into bisq-network:master Mar 17, 2021
@chimp1984 chimp1984 deleted the add-pay-from-bsq-wallet-button branch November 18, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @ripcurlx @wallclockbuilder