Improve portfolio history #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chimp1984
commented
Mar 15, 2021
- Improve csv export
- Fix incorrect taker miner fee
- Add summary windows for trade history
Separate volume with currency (add new column for currency) Separate trade fee in btc and bsq, remove currency from value Replace "-" with empty string Improve detection of bsq fee tx. Previous version was more complicate and would not have covered case where BSQ fee input matches exactly required fee so not BSQ output would have been created.
We had only displayed the fee for 1 tx, but taker pays 3 times that fee. The real miner fee is a bit higher in case we used BSQ as we add the burned BSQ to miner fee, we ignore that small difference as it would add more complexity and for that use case it't not that important to be exact.
We need to use fee from trade not from offer
|
|
ripcurlx
approved these changes
Mar 16, 2021
|
No % of trade deviation in history? e.g. -3% etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.