Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2P initialization is reverted to the order before #5219 changed it. Then the mailbox initialization is split into a part done before listener modules, and a part after all other initialization is done.
Fixes #5265
Details:
TradeManager expects MailboxMessageService to be bootstrapped in order to re-send trade messages at startup, e.g. (CounterCurrencyPaymentStartedMessage). MailboxMessageService implicitly depends on TradeManager to be bootstrapped, because it forwards a dispute message which in turn depends on Trade and TradeManager.
The following scenarios are relevant for testing, as are all messages processed or resent at startup.
1. Dispute opened while Bob was offline. (#5210)
2. With Alice offline, Bob started payment then reboots. (#5265)