Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mailbox bootstrap issue #5267

Merged
merged 1 commit into from Mar 3, 2021
Merged

Fix mailbox bootstrap issue #5267

merged 1 commit into from Mar 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2021

P2P initialization is reverted to the order before #5219 changed it. Then the mailbox initialization is split into a part done before listener modules, and a part after all other initialization is done.

Fixes #5265


Details:

TradeManager expects MailboxMessageService to be bootstrapped in order to re-send trade messages at startup, e.g. (CounterCurrencyPaymentStartedMessage). MailboxMessageService implicitly depends on TradeManager to be bootstrapped, because it forwards a dispute message which in turn depends on Trade and TradeManager.


The following scenarios are relevant for testing, as are all messages processed or resent at startup.

1. Dispute opened while Bob was offline. (#5210)

  • Alice has published a buy offer
  • Bob has taken the buy offer
  • Alice requests support when Bob is offline
  • Bob returns online and the exception is launched

2. With Alice offline, Bob started payment then reboots. (#5265)

  • Bob makes offer to buy
  • Alice takes offer
  • Alice goes offline
  • Blockchain confirms
  • Bob initiates payment
  • Bob shuts down and restarts bisq, then the error message is reported at startup.

Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost ghost changed the title fix mailbox bootstrap issue Fix mailbox bootstrap issue Mar 2, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 3b1158a into bisq-network:master Mar 3, 2021
@ripcurlx ripcurlx added this to the v1.5.9 milestone Mar 3, 2021
@ghost ghost mentioned this pull request Mar 3, 2021
@ripcurlx ripcurlx modified the milestones: v1.5.9, v1.6.0 Mar 11, 2021
@ghost ghost deleted the fix_mailbox_bootstrap branch May 29, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug trade failed after update to 1.5.8, error message, BuyerSendCounterCurrencyTransferStartedMessage
2 participants