Fix multiple request preliminary data calls #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove SetupListener implementation from MailboxMessageService. Remove requestDataManager Add onNoSeedNodeAvailable method Call onNoSeedNodeAvailable from P2PService
mailboxMessageService.onBootstrapped(); and onUpdatedDataReceived mailboxMessageService depends on p2PDataStorage so we make sure the p2PDataStorage is updated before we update the mailboxMessageService state.
…a is false We did not do all the calls before (like on p2pDataStorage), so that changes behaviour.
and call onNoSeedNodeAvailable instead.
ripcurlx
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
ACK - Code looks fine IMO and I tested it on Mainnet re-producing the error and afterwards successfully starting with this fix. Actually I had exactly this issue the other day while having tor connections issue which I mentioned in the #ops channel. Should have investigated into this immediately myself. Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5204
The PR is done in small improvements steps. Feel free to use final version instead of reviewing all commits.