Manual payout tool: prevent absurdly high fee payout #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- trims whitespace from numeric input fields before parsing - adds percentage display of the tx fee - validates that the tx fee percentage is not higher than 10%
chimp1984
suggested changes
Jan 21, 2021
| @@ -544,6 +553,8 @@ private void calculateTxFee() { | |||
| .subtract(getInputFieldAsCoin(buyerPayoutAmount)) | |||
| .subtract(getInputFieldAsCoin(sellerPayoutAmount)); | |||
| txFee.setText(txFeeValue.toPlainString()); | |||
| double feePercent = (double) txFeeValue.value / getInputFieldAsCoin(amountInMultisig).value; | |||
There was a problem hiding this comment.
Maybe safer to wrap it into a try catch? E.g. if getInputFieldAsCoin(amountInMultisig).value can be 0 it would throw an exception.
There was a problem hiding this comment.
No exception, it returns -Infinity. So I don't see any issue.
|
I just cherry-picked it into the release branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds display of the Tx fee as a percentage, and includes validation to disallow the payout processing if tx fee is > 10% of the multisig amount. The Tx cannot be signed or built until validation passes.
Fixes a bug whereby whitespace in an amount caused it to be parsed as 0. It now trims whitespace from numeric input fields before parsing.
Screenshot showing the new Tx fee % field: