Avoid reverse DNS lookup in BtcNodeConverterTest #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent failure of testConvertClearNode() on some machines, caused by use of InetAddress.getHostName on the mock peer address. This does a reverse DNS lookup and potentially returns something other than the expected "192.168.0.1" string. Also avoid an unnecessary getHostName() call on the SOCKS5 Tor proxy InetAddress in WalletConfig, by using an alternative InetSocketAddress constructor.
|
Rebasing onto a more recent version of master to force a rebuild... |
bc72345 to
3dd552c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent failure of
testConvertClearNode()on some machines, caused by use ofInetAddress.getHostNameon the mock peer address. This does a reverse DNS lookup and potentially returns something other than the expected "192.168.0.1" string. (For example, on my current local network I get "BrightBox.ee".)Also avoid an unnecessary
getHostName()call on the SOCKS5 Tor proxy InetAddress inWalletConfig, by using an alternativeInetSocketAddressconstructor.