-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v1.5.2 #5012
Merged
Merged
Release/v1.5.2 #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sort according to it Allow sorting at show all. This helps to spot good offers with negative % over the whole market.
Cleanups
call and does not change frequently and is only used for informational purpose as % display.
Fix test with price display.
Use bitcoinj 0.15.8.bisq.13 (commit dcf8af0)
If oen starts with --daoActivated=false there is no service set up in one of the data store services so it never calls the result handler and the app never starts up.
Redesign the UI Add import/export of payout settings Add ability to import from mediation ticket Mediator does not need private key User can sign using own wallet or private key Validation of input fields Calculate the tx fee based on inputs Display of the generated txid & hex so it can be checked
Supporting three digits in this UI element wouldn't work properly in all our use cases
[v1.5.2] Update data stores for v1.5.2
We request each min. the price feed so that get very verbose
For 1.3.9 filter we expect a error log but dont want to show it as warning
…y banned, but rather deactivated/revoked node
As its generic here we cannot influence log level
… mostly an expected case.
We iterate over all trades and messages, so it is expected that the msg which are not assigned to that trade fails. We need to change the handleDecryptedMessageWithPubKey to check first if the msg and trade matches, but that will be done in a dedicated PR.
A Nullpointer can happen if app get shut down very early.
See: https://twitter.com/cenbank/status/1339196770774093825 I tested it with setting that currency, doing offers and trades, then remove it and continue the trades. Offers with NGN cannot be taken anymore.
[1.5.2] Remove NGN (Nigerian Naira) as their central bank blocked Transferwise
[1.5.2] Fix nullpointer
[1.5.2] Improve logs
this supports the historical data store. Using p2PService.getP2PDataStorage().getAppendOnlyDataStoreMap() would not deliver all the data. User stream API
Change shortcut to copy account info for witness signing to ctrl+shift+c to avoid conflicts with standard OS shortcuts.
Avoid standard shortcuts
…cess [1.5.2] Fix wrong account age data access
…t-cards [1.5.2] Add extra note for amazon gift cards
…tion-window [v1.5.2] Fix private notification style issue in dark mode
A new acct now has no default trade currencies. Also fixed imports to not mix jupiter and junit asserts.
….5.2 # Conflicts: # core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java # core/src/main/java/bisq/core/trade/closed/CleanupMailboxMessages.java
sqrrm
approved these changes
Dec 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.