Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data stores for v1.5.0 #4792

Merged

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Nov 13, 2020

Light node in light mode and full node in dark mode

Bildschirmfoto 2020-11-13 um 12 00 02

Bildschirmfoto 2020-11-13 um 11 59 57

Bildschirmfoto 2020-11-13 um 11 59 52

Bildschirmfoto 2020-11-13 um 11 59 48

Bildschirmfoto 2020-11-13 um 11 59 43

Bildschirmfoto 2020-11-13 um 11 59 40

@ripcurlx ripcurlx changed the base branch from master to release/v1.5.0 November 13, 2020 12:40
@ripcurlx ripcurlx requested a review from sqrrm November 13, 2020 12:41
@ripcurlx
Copy link
Contributor Author

@chimp1984 Could you please have a look at the trade statistics 3 data store? Thanks!

@sqrrm
Copy link
Member

sqrrm commented Nov 13, 2020

I wonder about the TradeStatistics3Store. It's different size to what I get when I run from my own old instance. I thought they should be the same (apart from new trades within the last couple of minutes after my restart).

The other stores look good.

@chimp1984
Copy link
Contributor

Git lfs download takes ages... Will test once its downloaded. I have a local file which is about 20 kb larger, but might be the missing prune...

@chimp1984
Copy link
Contributor

I have roughly the same file size with a fresh app. So TradeStatistics3Store_1.5.0 looks good to me.

Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit 627e067 into bisq-network:release/v1.5.0 Nov 14, 2020
@ripcurlx ripcurlx deleted the update-data-stores-for-v1.5.0 branch July 16, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants