Pricenode tweak: completely remove Coinmate and cex.io as data providers #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on user feedback, these exchanges are too illiquid and do not accurately reflect the true price of the market. After research, I found the user's feedback to be correct and this PR removes both exchanges.
|
Wouldn't it be cleaner to set the exchange weights to zero? In this way when the exchange gains relevance or is useful for another crypto pair it's still available. Don't want to block this PR, just something to keep in mind for the future |
|
I think this can be deployed pretty fast as long as price node operators coordinate. |
|
How about just disabling them, instead of removing? They can be easily disabled by commenting out the |
|
Too late, I didn't notice its already merged. |
|
If you want to, just revert this PR and disable as you suggest. Sounds more appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on user feedback, these exchanges are too illiquid and do not accurately reflect the true price of the market. After research, I found the user's feedback to be correct and this PR removes both exchanges.