Update seednode/pricenode install scripts #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install_collectd_debian.sh script reads user input to obtain the onion address. However, when you pipe the output of curl into the shell you're making the script text be standard input of the shell, which takes it in as commands to run. After that, there's nothing left to read. Even if it were to try, it wouldn't get anything from the terminal input, because it's not connected to it. The pipe has replaced standard input for the shell process. Instead, create a pipe for bash to read the output of curl from and provide it as the script file argument. In this case, the standard input of the script is still connected to the terminal, and read will work.
cbeams
approved these changes
Jun 18, 2020
|
@wiz Could you have a look at this changes before I merge this based on #4319 (review) |
|
utACK |
wiz
reviewed
Jul 27, 2020
| @@ -34,6 +34,11 @@ echo "[*] Upgrading apt packages" | |||
| sudo -H -i -u "${ROOT_USER}" DEBIAN_FRONTEND=noninteractive apt-get update -q | |||
| sudo -H -i -u "${ROOT_USER}" DEBIAN_FRONTEND=noninteractive apt-get upgrade -qq -y | |||
|
|
|||
| echo "[*] Installing Git LFS" | |||
| sudo -H -i -u "${ROOT_USER}" curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | bash | |||
There was a problem hiding this comment.
Why is this needed? Doesn't ubuntu have a git-lfs package by default?
There was a problem hiding this comment.
I also think apt install git-lfs should work just fine. No need for external packages.
There was a problem hiding this comment.
This is used to ensure the latest git-lfs package is installed. I don't recall now, but perhaps the latest isn't necessary for our needs and it should be fine to remove this line.
https://github.com/git-lfs/git-lfs/wiki/Installation#debian-and-ubuntu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deploying a new seednode instance on Ubuntu 20.04, I ran into a few issues with the install script and README. This PR addresses those issues.