Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and rename Portfolio History columns meaningfully. #3785

Closed
wants to merge 3 commits into from
Closed

Add and rename Portfolio History columns meaningfully. #3785

wants to merge 3 commits into from

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Dec 13, 2019 •
edited
Loading

Fixes #3338.

Related to #2106

@niyid niyid requested review from ripcurlx and sqrrm as code owners December 13, 2019 00:11
@niyid niyid mentioned this pull request Dec 13, 2019
Closed
@stale
Copy link

stale bot commented Jan 12, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jan 12, 2020
ripcurlx
ripcurlx suggested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Because of code format issues. Please also rebase your PR against master so it is easier also to test with a mainnet client. Thanks!

desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java Outdated Show resolved Hide resolved
@stale stale bot removed was:dropped labels Jan 13, 2020
@niyid niyid requested a review from ripcurlx January 14, 2020 07:20
@ripcurlx
Copy link
Contributor

@niyid I activated yesterday codacy's PR Quality Review for the Bisq repository. It found for your PR a couple of issues which you can view in the Details link next to the PR check. Please review and push fixes for this issues to trigger a re-review by codacy. Thanks!

@niyid
Copy link
Contributor Author

niyid commented Feb 8, 2020

@ripcurlx
A "waiting for author" label was added 26 days ago. I am not sure it was intended to be active on this PR for that long.

@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Closed
ripcurlx
ripcurlx suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

Please see my comments and also please rebase against master to make it easier to review. Thanks!

desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java Outdated Show resolved Hide resolved
@niyid niyid requested a review from ripcurlx February 27, 2020 01:42
@niyid
Copy link
Contributor Author

niyid commented Feb 27, 2020

@ripcurlx All issues resolved. Please remember to remove "waiting for author" label.

@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Closed
@stale
Copy link

stale bot commented Mar 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Mar 28, 2020
@stale
Copy link

stale bot commented Apr 4, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm Awaiting requested review from sqrrm

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

Assignees
No one assigned
Labels
was:dropped
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add and rename Portfolio History columns meaningfully
2 participants
@niyid @ripcurlx