Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data stores, translations and bitcoinj checkpoints #3748

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Dec 4, 2019

Here are the hash screenshots for the new data stores (from full node in dark mode). I've added the state from my light node (in light mode) for comparison.
Bildschirmfoto 2019-12-04 um 22 11 08
Bildschirmfoto 2019-12-04 um 22 11 16
Bildschirmfoto 2019-12-04 um 22 11 39
Bildschirmfoto 2019-12-04 um 22 11 24Bildschirmfoto 2019-12-04 um 22 11 55
Bildschirmfoto 2019-12-04 um 22 12 02

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Dec 4, 2019

I'll merge this PR without review as it is mainly for documentation reason (screenshots).
@julianknutsen Maybe you could compare it with your locale node state to get another confirmation for this data stores.

@ripcurlx ripcurlx merged commit acd4350 into bisq-network:release/v1.2.4 Dec 4, 2019
@ripcurlx ripcurlx deleted the release/v1.2.4 branch December 4, 2019 21:26
@julianknutsen
Copy link
Contributor

Verified that the screenshots match my local state for the DAO, Proposal, and Blind Vote states.

Copy link
Contributor

@arunasurya arunasurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at another Transifex issue and noticed that some strings seem to have reverted to English.

@@ -1961,7 +1961,7 @@ showWalletDataWindow.includePrivKeys=Private Schlüssel einbeziehen
tacWindow.headline=Nutzervereinbarung
tacWindow.agree=Ich stimme zu
tacWindow.disagree=Ich stimme nicht zu und beende
tacWindow.arbitrationSystem=Vermittlersystem
tacWindow.arbitrationSystem=Dispute resolution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the German translation (and others, see below) reverted to English?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into this briefly in Transifex and the string did change from "Vermittlersystem" to "Streitbeilegung" about a month ago but it seems that something went wrong when importing the new strings into the git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants