Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing.md #3613

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Update contributing.md #3613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a9cf88
Fixed spelling in Contributing.md
freimair Nov 15, 2019
95d7b0e
Added PR timeout info
freimair Nov 15, 2019
8b76a44
Remove optional signing info
freimair Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ All Bisq contributors submit changes via pull requests. The workflow is as follo
- Squash redundant or unnecessary commits
- Submit a pull request from your topic branch back to the `master` branch of the main repository

Pull requests should be focused on a single change. Do not mix, for example, refactorings with a bug fix or implementation of a new feature. This practice makes it easier for fellow contributors to review each pull request on its merits and and to give a clear ACK/NACK (see below).
Pull requests should be focused on a single change. Do not mix, for example, refactorings with a bug fix or implementation of a new feature. This practice makes it easier for fellow contributors to review each pull request on its merits and to give a clear ACK/NACK (see below).


## Reviewing Pull Requests
Expand All @@ -37,6 +37,8 @@ Anyone may participate in peer review which is expressed by comments in the pull
- `Concept ACK` means "I agree in the general principle of this pull request";
- `Nit` refers to trivial, often non-blocking issues.

Please note that Pull Requests marked `NACK` and/or Github's `Change requested` are closed after 30 days if not addressed.


## Compensation

Expand Down Expand Up @@ -65,8 +67,6 @@ See also [bisq-network/style#9](https://github.com/bisq-network/style/issues/9).

### Sign your commits with GPG

_Not strictly required, but recommended for those who commit frequently._

See https://github.com/blog/2144-gpg-signature-verification for background and
https://help.github.com/articles/signing-commits-with-gpg/ for instructions.

Expand Down