Merge P2P bugfixes into seednode branch to help node stability issues #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freimair
approved these changes
Aug 28, 2019
| // We must set the listeners initially and not on onParseBlockChainComplete as activeOrMyUnconfirmedProposals | ||
| // is used in voteResults which can be called earlier during sync. | ||
| // To avoid unneeded upDateLists calls we delay one render frame so that once the proposalService is complete we | ||
| // register out listeners. |
There was a problem hiding this comment.
Suggested change
| // register out listeners. | |
| // register our listeners. |
| public void start() { | ||
| // We must set the listeners initially and not on onParseBlockChainComplete as activeOrMyUnconfirmedProposals | ||
| // is used in voteResults which can be called earlier during sync. | ||
| // To avoid unneeded upDateLists calls we delay one render frame so that once the proposalService is complete we |
There was a problem hiding this comment.
Suggested change
| // To avoid unneeded upDateLists calls we delay one render frame so that once the proposalService is complete we | |
| // To avoid unneeded updateLists(); calls, we delay one render frame so that once the proposalService is complete, we |
| @@ -31,7 +31,7 @@ | |||
| PROPOSAL, | |||
| BLIND_VOTE, | |||
| ACK_MSG, | |||
| BSQ_BLOCK, | |||
| RECEIVE_BSQ_BLOCK, | |||
There was a problem hiding this comment.
I am not sure we should change stuff like that. What I am sure of is that we should add Javadoc to describe what a capability is for and what it does, only so can we make sure devs can understand what these 2 or 3 words mean.
This was referenced Sep 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.