Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various optimizations #3112

Merged
merged 7 commits into from
Aug 20, 2019
Merged

Various optimizations #3112

merged 7 commits into from
Aug 20, 2019

Conversation

freimair
Copy link
Contributor

Various optimizations to the Bisq code

  • reduce info to debug log on spamming infos
  • do not do parsing until everything is completed and thus, save on resources and time

ManfredKarrer
ManfredKarrer suggested changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

See comment

core/src/main/java/bisq/core/dao/governance/proposal/ProposalValidator.java Outdated Show resolved Hide resolved
ManfredKarrer
ManfredKarrer approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@freimair freimair mentioned this pull request Aug 20, 2019
Closed
sqrrm
sqrrm approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit f2f62c7 into bisq-network:master Aug 20, 2019
This was referenced Sep 1, 2019
Closed
Closed
Closed
@sqrrm sqrrm mentioned this pull request Sep 9, 2019
Closed
@freimair freimair mentioned this pull request Sep 16, 2019
Closed
@freimair freimair deleted the optimizations branch April 2, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophsturm christophsturm christophsturm left review comments

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

@sqrrm sqrrm sqrrm approved these changes

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@freimair @christophsturm @ManfredKarrer @sqrrm