Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render proper column headers and values for CSV exports; fix #3075 #3090

Conversation

battleofwizards
Copy link
Contributor

When exporting to CSV, both portfolio/trades and funds/transactions were lacking the column headers.

Additionally, portfolio/trades colum values were outdated and not matching the intended export.

Both issues are fixed.

…work#3075

When exporting to CSV, both portfolio/trades and funds/transactions
were lacking the column headers.

Additionally, portfolio/trades colum values were outdated and
not matching the intended export.

Both issues are fixed.
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@freimair freimair merged commit 9763753 into bisq-network:master Aug 14, 2019
@battleofwizards battleofwizards deleted the render-column-headers-in-csv-export branch September 20, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants