Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define missing dependency version variables #3052

Merged
merged 7 commits into from
Aug 14, 2019
Merged

Define missing dependency version variables #3052

merged 7 commits into from
Aug 14, 2019

Conversation

ghubstan
Copy link
Contributor

@ghubstan ghubstan commented Aug 3, 2019

Created version variables in build.gradle where missing,
but not changing hard coded overrides in subprojects.

Alphanumerically ordered version variables.

Used IDE code formatter, changing top line of file.

No issue related to this patch: a new contributor's effort to help maintain consistency in the build file.

Created version variables in build.gradle where missing,
but not touching hard coded overrides in subprojects.

Alphanumerically ordered version variables.

Used IDE code formatter, changing top line of file.
@ghubstan
Copy link
Contributor Author

ghubstan commented Aug 3, 2019

Apologies for not using a topic branch off my fork, as per the Contributor Workflow instructions in
https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md

I will do so from now on.

Copy link
Contributor

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

Thanks for taking care of that.

@freimair freimair merged commit 6e98a49 into bisq-network:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants