Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of editing of offers with invalid security deposit #2740

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Improve handling of editing of offers with invalid security deposit #2740

merged 1 commit into from
Apr 20, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Apr 18, 2019 •
edited
Loading

Shows warning popup when offer with invalid security deposit is edited.
@m52go Could you please review the text? Thanks!
Bildschirmfoto 2019-04-18 um 13 19 24

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner April 18, 2019 11:23
@ripcurlx ripcurlx requested a review from m52go April 18, 2019 11:24
@m52go
Copy link
Contributor

m52go commented Apr 18, 2019

Here is a general message:

The buyer's security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

If this message will always be shown to the person making the edit, I would suggest simply saying:

Your security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

@ripcurlx
Copy link
Contributor Author

Here is a general message:

The buyer's security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

If this message will always be shown to the person making the edit, I would suggest simply saying:

Your security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

It will always be the maker, but she can be the buyer or seller. So I'll go with the general message -thx!

@ripcurlx ripcurlx force-pushed the handle-editing-of-offers-with-invalid-deposit branch from ba81b54 to 8481593 Compare April 18, 2019 12:45
ManfredKarrer
ManfredKarrer approved these changes Apr 20, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 2f44971 into bisq-network:master Apr 20, 2019
@ripcurlx ripcurlx mentioned this pull request May 3, 2019
Closed
@m52go m52go mentioned this pull request May 9, 2019
Closed
@ripcurlx ripcurlx deleted the handle-editing-of-offers-with-invalid-deposit branch September 26, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

@m52go m52go Awaiting requested review from m52go

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ripcurlx @m52go @ManfredKarrer