Use btcNodes argument in regtest mode. #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +196,7 @@ protected void onSetupCompleted() { | |||
| }; | |||
|
|
|||
| if (params == RegTestParams.get()) { | |||
| configPeerNodesForRegTest(); | |||
| configPeerNodesForRegTest(socks5Proxy); | |||
There was a problem hiding this comment.
I would prefer to have additional checks here and not call configPeerNodes(proxy); from configPeerNodesForRegTest. What is the usecase that you need?
There was a problem hiding this comment.
When each node runs in separate docker container they have different IPs and are not reachable by localhost. Regtest mode currently forces to use specific bitcoin node IP or tries to use localhost.
I need ability to point bisq to specific IP in regtest mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for bisq-api and bitcoin docker containers to see each other during dockerized regtest.