Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof of burn signing does not work if wallet password is set #3836

Closed
burningman2 opened this issue Dec 28, 2019 · 0 comments · Fixed by #4221
Closed

Proof of burn signing does not work if wallet password is set #3836

burningman2 opened this issue Dec 28, 2019 · 0 comments · Fixed by #4221
Labels
a:bug in:dao

Comments

@burningman2
Copy link

Description

Signing with proof of burn only works if wallet password is removed

Version

1.2.4
stejbac added a commit to stejbac/bisq that referenced this issue May 1, 2020
@stejbac
Fix proof-of-burn signing for password protected wallets
9dce794 
Add a missing bsqWalletService.isEncrypted() check and optional AES key
argument to the signMessage(..) call in ProofOfBurnService, analogous to
the BitcoinJ call to sign with an EC key in MyBlindVoteListService.

This fixes bisq-network#3836.
@stejbac stejbac mentioned this issue May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:dao
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix proof-of-burn signing for password protected wallets stejbac/bisq
2 participants
@ripcurlx @burningman2