-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode not disabled on 1st attempt to turn it off after restart #3447
Comments
I am not sure if I catch the issue here. Your expected/actual results are for step 5 or afterwards? |
The expected/actual results apply to step 5. |
This issue also exists in Bisq 1.2.3 on Fedora 30. If the dark mode button is moved to light mode, and then user goes to any other part of the app, and then returns to Settings, the dark mode selector automatically moves back to dark mode. So, in my case, not able to turn off dark mode at all yet. |
@wiz Could you please have a look at it? Thanks! |
Apparently the preferences property listener I was using doesn't call the event handler on the first change for some reason. This is a workaround to change the CSS theme directly from the slider switch. Needs review and testing! Fixes bisq-network#3447
[How to Reproduce]
[Expected Results]
Dark mode is disabled on 1st attempt to turn it off.
[Actual Results]
![DarkModeNotDisabled](https://user-images.githubusercontent.com/36207203/67396315-b8b38280-f57d-11e9-9c48-2beab02c13d3.png)
Dark mode is not disabled on 1st attempt to turn it off (see bottom left of screen shot below).
It is disabled on 2nd attempt to turn it off.
This issue was discovered during v1.2.0 testing .
The text was updated successfully, but these errors were encountered: