Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode not disabled on 1st attempt to turn it off after restart #3447

Closed
ghubstan opened this issue Oct 23, 2019 · 4 comments · Fixed by #3771
Closed

Dark mode not disabled on 1st attempt to turn it off after restart #3447

ghubstan opened this issue Oct 23, 2019 · 4 comments · Fixed by #3771

Comments

@ghubstan
Copy link
Contributor

[How to Reproduce]

  1. Start arbitration desktop on Ubuntu 18
  2. Enable dark mode
  3. Shut down desktop
  4. Restart arbitration desktop
  5. Disable dark mode

[Expected Results]
Dark mode is disabled on 1st attempt to turn it off.

[Actual Results]
Dark mode is not disabled on 1st attempt to turn it off (see bottom left of screen shot below).
It is disabled on 2nd attempt to turn it off.
DarkModeNotDisabled

This issue was discovered during v1.2.0 testing .

@freimair
Copy link
Contributor

freimair commented Oct 31, 2019

I am not sure if I catch the issue here. Your expected/actual results are for step 5 or afterwards?

@ghubstan
Copy link
Contributor Author

The expected/actual results apply to step 5.
When you disable dark mode (5), nothing happens.
It does work after you slide the button back to the left, then slide it to the right a second time.

@Bigsy11
Copy link

Bigsy11 commented Dec 3, 2019

This issue also exists in Bisq 1.2.3 on Fedora 30.
If dark mode is disabled and Bisq restarted, it comes back in dark mode.
Tried 3 Bisq restarts just now.

If the dark mode button is moved to light mode, and then user goes to any other part of the app, and then returns to Settings, the dark mode selector automatically moves back to dark mode.

So, in my case, not able to turn off dark mode at all yet.

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 3, 2019

This issue also exists in Bisq 1.2.3 on Fedora 30.
If dark mode is disabled and Bisq restarted, it comes back in dark mode.
Tried 3 Bisq restarts just now.

If the dark mode button is moved to light mode, and then user goes to any other part of the app, and then returns to Settings, the dark mode selector automatically moves back to dark mode.

So, in my case, not able to turn off dark mode at all yet.

@wiz Could you please have a look at it? Thanks!

wiz added a commit to wiz/bisq that referenced this issue Dec 6, 2019
Apparently the preferences property listener I was using doesn't call
the event handler on the first change for some reason. This is a
workaround to change the CSS theme directly from the slider switch.

Needs review and testing! Fixes bisq-network#3447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants