Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition(?) while entering text in autocomplete dropdown #3171

Closed
wiz opened this issue Aug 31, 2019 · 4 comments · Fixed by #3172
Closed

Race condition(?) while entering text in autocomplete dropdown #3171

wiz opened this issue Aug 31, 2019 · 4 comments · Fixed by #3172

Comments

@wiz
Copy link
Contributor

wiz commented Aug 31, 2019 •
edited
Loading

[How to Reproduce]

  1. Click on Buy BTC from top navigation
  2. Double click on "Filter by currency" autocomplete dropdown
  3. Type in "USD"

[Expected Result]
Field should contain "USD"

[Actual Result]
Field contains "DUS all"

combobox

@battleofwizards
@battleofwizards
Copy link
Contributor

battleofwizards commented Aug 31, 2019 •
edited
Loading

Obviously, you are correct about the expected behavior.

Does it happen right out of the box for you? Or some preparatory "playing" with the app is first required?

Does it happen pretty much all the time? Or occasionally?

@wiz
Copy link
Contributor Author

wiz commented Aug 31, 2019

It reproduces 100% when the text is selected by any method, for example double click and triple click also reproduce this bug so JPY -> PYJ

@battleofwizards
Copy link
Contributor

Got it!

Could you please change the "How to reproduce" step 2. to "Double-click" so others can easily recreate the problem?

Can you confirm the single-click is fine?

@wiz
Copy link
Contributor Author

wiz commented Aug 31, 2019

Great. Yeah, since single click does not select text, it does not reproduce this issue.

battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 31, 2019
@battleofwizards
Fix bisq-network#3171 doubleclick on autocomplete dropdowns
73c8832
@battleofwizards battleofwizards mentioned this issue Aug 31, 2019
Merged
ripcurlx added a commit that referenced this issue Sep 2, 2019
@ripcurlx
Merge pull request #3172 from battleofwizards/fix-doubleclick-on-auto…
f972984 
…complete-dropdowns

Fix #3171 doubleclick on autocomplete dropdowns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3171 doubleclick on autocomplete dropdowns battleofwizards/bisq
2 participants
@wiz @battleofwizards