-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSS feed hyperlink #198
Conversation
I added hyperlinks to /blog/index.html and /_layouts/post.html.
@huey735 could we make the icon slightly smaller and better vertically aligned? Before After May seem like a nit-pick for desktop but it makes a visible difference on smaller screens, especially phone screens. Below is the markup I used. anchor tag -->
img tag -->
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m52go I added the css line inline, inside the html tags. I'm not sure if that's what you meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huey735 sorry I should've been more specific. I'd prefer to see CSS markup kept separate from HTML markup. I suggested HTML changes in-line. Here is the accompanying CSS markup:
.rss-link {
float: right;
width: 30px;
height: auto;
}
.rss-link img {
width: 100%;
}
.rss-link.blog-index {
margin-top: 9px;
}
.rss-link.post {
margin-top: 4px;
}
.post.type-post .dets h2, h1#blog-index-header {
padding-right: 50px;
}
If you accept my HTML suggestions and add this markup to css/styles.css
(ideally in the section marked 'blog' after line 707), it should be good.
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
ACK |
I forgot to change the ID of the blog index page header in my suggestions, so I'll follow this merge with that small tweak. |
I added hyperlinks to /blog/index.html and /_layouts/post.html.
I didn't make any change to /_layouts/post-report.html.