Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSS feed hyperlink #198

Merged
merged 5 commits into from
Aug 6, 2019
Merged

Add RSS feed hyperlink #198

merged 5 commits into from
Aug 6, 2019

Conversation

huey735
Copy link
Contributor

@huey735 huey735 commented Jul 26, 2019

I added hyperlinks to /blog/index.html and /_layouts/post.html.
I didn't make any change to /_layouts/post-report.html.

I added hyperlinks to /blog/index.html and
/_layouts/post.html.
@m52go
Copy link
Contributor

m52go commented Aug 1, 2019

@huey735 could we make the icon slightly smaller and better vertically aligned?

Before

Screenshot from 2019-08-01 13-18-55

After

Screenshot from 2019-08-01 13-18-40

May seem like a nit-pick for desktop but it makes a visible difference on smaller screens, especially phone screens. Below is the markup I used.

anchor tag -->

display: inline-block;
float: right;
margin-top: 9px;

img tag -->

width: 30px;

Copy link
Contributor Author

@huey735 huey735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m52go I added the css line inline, inside the html tags. I'm not sure if that's what you meant.

Copy link
Contributor

@m52go m52go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huey735 sorry I should've been more specific. I'd prefer to see CSS markup kept separate from HTML markup. I suggested HTML changes in-line. Here is the accompanying CSS markup:

.rss-link {
    float: right;
    width: 30px;
    height: auto;
}

.rss-link img {
    width: 100%;
}

.rss-link.blog-index {
    margin-top: 9px;
}

.rss-link.post {
    margin-top: 4px;
}

.post.type-post .dets h2, h1#blog-index-header {
    padding-right: 50px;
}

If you accept my HTML suggestions and add this markup to css/styles.css (ideally in the section marked 'blog' after line 707), it should be good.

_layouts/post.html Outdated Show resolved Hide resolved
blog/index.html Outdated Show resolved Hide resolved
huey735 and others added 3 commits August 5, 2019 18:42
Co-Authored-By: Steve Jain <mfiver@gmail.com>
Co-Authored-By: Steve Jain <mfiver@gmail.com>
@m52go
Copy link
Contributor

m52go commented Aug 6, 2019

ACK

@m52go
Copy link
Contributor

m52go commented Aug 6, 2019

I forgot to change the ID of the blog index page header in my suggestions, so I'll follow this merge with that small tweak.

@m52go m52go merged commit befbfa1 into bisq-network:master Aug 6, 2019
@huey735 huey735 deleted the rssfeed branch August 6, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants