Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor security issues #142

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Fix minor security issues #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af02c65
Improve site isolation
ripcurlx Mar 7, 2019
e105dfd
Update libraries because of security vulnerabilities
ripcurlx Mar 7, 2019
a0a88bc
Remove site webmanifest link as we don't have one
ripcurlx Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _data/dao_content.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
href_text: Learn more about the DAO ›
href: "https://docs.bisq.network/dao.html"
target: "_blank"
rel: "noopener"
img: ../images/DAO/dao_why.svg
id: why

Expand All @@ -39,6 +40,7 @@
href_text: Learn more about the DAO ›
href: "https://docs.bisq.network/dao.html"
target: "_blank"
rel: "noopener"
img: ../images/DAO/dao_what.svg
id: what

Expand Down Expand Up @@ -83,6 +85,7 @@
href_text: Learn more about the DAO ›
href: "https://docs.bisq.network/dao.html"
target: "_blank"
rel: "noopener"
img: ../images/DAO/dao_how.svg
id: how

Expand All @@ -107,5 +110,6 @@
href_text: Learn more about the DAO ›
href: "https://docs.bisq.network/dao.html"
target: "_blank"
rel: "noopener"
img: ../images/DAO/dao_benefits.svg
id: benefits
24 changes: 12 additions & 12 deletions _includes/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@

<div class="col-12 col-lg-4 mt-md-0 mt-3 pl-md-5 pl-sm-3 small px-sm-4 px-4">
<h5 class="text-uppercase small grey">Bisq mobile notification App</h5>
<a target="_blank" class="app-link" href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq"><img class="badge-img" alt="Get it on Google Play" src="{{ site.url }}/images/badge_google_play.svg"/></a>
<a target="_blank" rel="noopener" class="app-link" href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq"><img class="badge-img" alt="Get it on Google Play" src="{{ site.url }}/images/badge_google_play.svg"/></a>
&nbsp;
<a target="_blank" class="app-link" href="https://itunes.apple.com/us/app/bisq-mobile/id1424420411"><img class="badge-img" alt="Get it on the App Store" src="{{ site.url }}/images/badge_app_store.svg"/></a>
<a target="_blank" rel="noopener" class="app-link" href="https://itunes.apple.com/us/app/bisq-mobile/id1424420411"><img class="badge-img" alt="Get it on the App Store" src="{{ site.url }}/images/badge_app_store.svg"/></a>


<div class="text-left small grey pt-4">
Expand Down Expand Up @@ -37,10 +37,10 @@ <h5 class="text-uppercase small grey">Resources</h5>
<a href="{{ site.url }}/roadmap">Roadmap</a>
</li>
<li>
<a href="https://docs.bisq.network/contributor-checklist.html" target="_blank">Contribute</a>
<a href="https://docs.bisq.network/contributor-checklist.html" target="_blank" rel="noopener">Contribute</a>
</li>
<li>
<a href="https://markets.bisq.network/api/" target="_blank">Market Data API</a>
<a href="https://markets.bisq.network/api/" target="_blank" rel="noopener">Market Data API</a>
</li>
<!--
lets activate it once we have a dynamic content
Expand All @@ -57,14 +57,14 @@ <h5 class="text-uppercase small grey">Resources</h5>
<h5 class="text-uppercase small grey">Join Bisq</h5>

<span id="community-footer">
<a target="_blank" title="GitHub" href="https://github.com/bisq-network"> <img src="{{ site.url }}/images/community/github_w.svg" alt="github"> </a>
<a target="_blank" title="Twitter" href="https://twitter.com/bisq_network"> <img src="{{ site.url }}/images/community/twitter_w.svg" alt="twitter"> </a>
<a target="_blank" title="YouTube" href="https://www.youtube.com/c/bisq-network"><img src="{{ site.url }}/images/community/youtube_w.svg" alt="youtube"> </a>
<a target="_blank" title="Slack" href="https://bisq.network/slack-invite"><img src="{{ site.url }}/images/community/slack_w.svg" alt="slack"> </a>
<a target="_blank" title="Bisq Forum" href="https://bisq.community"><img src="{{ site.url }}/images/community/forum_w.svg" alt="forum"> </a>
<a target="_blank" title="Mailing List" href="https://lists.bisq.network/listinfo/bisq-contrib"><img src="{{ site.url }}/images/community/mailinglist_w.svg" alt="mailinglist"> </a>
<a target="_blank" title="IRC" href="https://webchat.freenode.net/?channels=bisq"><img src="{{ site.url }}/images/community/irc_w.svg" alt="irc"> </a>
<a target="_blank" title="Reddit" href="https://www.reddit.com/r/bisq"><img src="{{ site.url }}/images/community/reddit_w.svg" alt="reddit"> </a>
<a target="_blank" rel="noopener" title="GitHub" href="https://github.com/bisq-network"> <img src="{{ site.url }}/images/community/github_w.svg" alt="github"> </a>
<a target="_blank" rel="noopener" title="Twitter" href="https://twitter.com/bisq_network"> <img src="{{ site.url }}/images/community/twitter_w.svg" alt="twitter"> </a>
<a target="_blank" rel="noopener" title="YouTube" href="https://www.youtube.com/c/bisq-network"><img src="{{ site.url }}/images/community/youtube_w.svg" alt="youtube"> </a>
<a target="_blank" rel="noopener" title="Slack" href="https://bisq.network/slack-invite"><img src="{{ site.url }}/images/community/slack_w.svg" alt="slack"> </a>
<a target="_blank" rel="noopener" title="Bisq Forum" href="https://bisq.community"><img src="{{ site.url }}/images/community/forum_w.svg" alt="forum"> </a>
<a target="_blank" rel="noopener" title="Mailing List" href="https://lists.bisq.network/listinfo/bisq-contrib"><img src="{{ site.url }}/images/community/mailinglist_w.svg" alt="mailinglist"> </a>
<a target="_blank" rel="noopener" title="IRC" href="https://webchat.freenode.net/?channels=bisq"><img src="{{ site.url }}/images/community/irc_w.svg" alt="irc"> </a>
<a target="_blank" rel="noopener" title="Reddit" href="https://www.reddit.com/r/bisq"><img src="{{ site.url }}/images/community/reddit_w.svg" alt="reddit"> </a>
</span>

</div>
Expand Down
12 changes: 6 additions & 6 deletions _includes/homepage_content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,21 +91,21 @@ <h1 class="intro text-monospace display-1" style="margin-left: -.3rem;"><span cl
</a>


<a href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq" target="_blank" class="downloads-android hidden btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn" onclick="ga('send', 'event', 'Jumbotron actions', 'download', 'android-notifications');">
<a href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq" target="_blank" rel="noopener" class="downloads-android hidden btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn" onclick="ga('send', 'event', 'Jumbotron actions', 'download', 'android-notifications');">
<img src="{{ site.url }}/images/icon-android-g.svg" class="os-icon os-icon-g">
<img src="{{ site.url }}/images/icon-android-w.svg" class="os-icon os-icon-w">
Get Android Notifications App
</a>


<a href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq" target="_blank" class="downloads-ios hidden btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn" onclick="ga('send', 'event', 'Jumbotron actions', 'download', 'ios-notifications');">
<a href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq" target="_blank" rel="noopener" class="downloads-ios hidden btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn" onclick="ga('send', 'event', 'Jumbotron actions', 'download', 'ios-notifications');">
<img src="{{ site.url }}/images/icon-apple-g.svg" class="os-icon os-icon-g">
<img src="{{ site.url }}/images/icon-apple-w.svg" class="os-icon os-icon-w">
Get iOS Notifications App
</a>


<a href="https://docs.bisq.network/getting-started.html" target="_blank" class="btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn">
<a href="https://docs.bisq.network/getting-started.html" target="_blank" rel="noopener" class="btn btn-lg btn-outline-secondary btn-icon hero-btn col-sm-12 col-md-12 col-lg-3 px-0 shadow-btn">
Get Started »
</a>

Expand Down Expand Up @@ -192,12 +192,12 @@ <h4>Secure and Always On</h4>
<div class="col-12 col-md-6 pr-5">
<img class="features-pic mb-4 mt-2 mt-md-5 mx-md-auto" src="{{ site.url }}/images/pic-open.svg" />
<h4>Open</h4>
<p class="grey px-md-5">Code is <a href="https://github.com/bisq-network/bisq" target="_blank">open source</a>, and project strategy is discussed openly on <a href="https://bisq.network/slack-invite" target="_blank">Slack</a> and <a href="https://github.com/bisq-network/bisq" target="_blank">GitHub</a>.</p>
<p class="grey px-md-5">Code is <a href="https://github.com/bisq-network/bisq" target="_blank" rel="noopener">open source</a>, and project strategy is discussed openly on <a href="https://bisq.network/slack-invite" target="_blank" rel="noopener">Slack</a> and <a href="https://github.com/bisq-network/bisq" target="_blank" rel="noopener">GitHub</a>.</p>
</div>
<div class="col-12 col-md-6 pr-5">
<img class="features-pic mb-4 mt-2 mt-md-5 mx-md-auto" src="{{ site.url }}/images/pic-easy.svg" />
<h4>Easy to Use</h4>
<p class="grey px-md-5">We've made all this sophistication simple—<a href='https://docs.bisq.network/getting-started' target='_blank'>make your first trade</a> in under 10 minutes!</p>
<p class="grey px-md-5">We've made all this sophistication simple—<a href='https://docs.bisq.network/getting-started' target='_blank' rel="noopener">make your first trade</a> in under 10 minutes!</p>
</div>
<div id='dao-coming-soon'><h3>Coming Soon: The Bisq DAO</h3><p>Decentralized governance for a decentralized exchange. <a href='https://docs.bisq.network/user-dao-intro.html'>Learn more here</a>.</p></div>
</div>
Expand Down Expand Up @@ -255,7 +255,7 @@ <h2 id="join-the-community">Join the Community</h2>
<div class="row">

<div class="col-12 col-md-6 grey bigger">
<p>Bisq is always looking for highly-skilled developers, designers and security experts to join our <a href="{{ site.url }}/community/">community</a>. If you’re interested in helping make Bisq better, there are many ways to <a href="https://docs.bisq.network/contributor-checklist.html" target="_blank">contribute</a>.
<p>Bisq is always looking for highly-skilled developers, designers and security experts to join our <a href="{{ site.url }}/community/">community</a>. If you’re interested in helping make Bisq better, there are many ways to <a href="https://docs.bisq.network/contributor-checklist.html" target="_blank" rel="noopener">contribute</a>.
We’d love to <a href="{{ site.url }}/community/">hear from you</a>!</p>
<p>Our <a href="{{ site.url }}/roadmap/">roadmap</a> provides an overview of high-level features and milestones on the way to Bisq v1.0.</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion _includes/main_nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
{% for item in site.data.main_nav.links %}
<li class="nav-item {% if page.url == item.url | append: '/' %}current{% endif %}">
{% if item.target == "_blank" %}
<a class="nav-link" target="{{ item.target }}" href="{{ item.url }}">{{ item.title }}</a>
<a class="nav-link" rel="noopener" target="{{ item.target }}" href="{{ item.url }}">{{ item.title }}</a>
{% else %}
<a class="nav-link" href="{{ site.url }}{{ item.url }}">{{ item.title }}</a>
{% endif %}
Expand Down
2 changes: 1 addition & 1 deletion _includes/positions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ <h5 class="mt-5 mb-sm-3 mb-5" id="brand-files">Contribute to Bisq</h5>

<p class="mb-5 pr-5">
We are always looking to grow our community of developers, designers and communication talents.<br><br>
Your contributions, if implemented and accepted by BSQ stakeholders, will be rewarded with BSQ. Read more <a href="https://docs.bisq.network/contributor-checklist.html" targe="_blank">here</a>.
Your contributions, if implemented and accepted by BSQ stakeholders, will be rewarded with BSQ. Read more <a href="https://docs.bisq.network/contributor-checklist.html" targe="_blank" rel="noopener">here</a>.
</p>

<div class="accordion border-bottom mb-5">
Expand Down
1 change: 0 additions & 1 deletion _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,6 @@
<link rel="icon" type="image/png" sizes="32x32" href="{{ site.url }}/images/bisq-fav.png">
<link rel="icon" type="image/png" sizes="16x16" href="{{ site.url }}/images/bisq-fav.png">
<link rel="icon" type="image/x-icon" href="{{ site.url }}/favicon.ico" />
<link rel="manifest" href="/site.webmanifest">
<link rel="mask-icon" href="/safari-pinned-tab.svg" color="#404040">
<meta name="msapplication-TileColor" content="#ffffff">
<meta name="theme-color" content="#ffffff">
Expand Down
4 changes: 2 additions & 2 deletions dao.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ <h2 style="margin: 2em 0;">Want to learn more?</h2>
Conceptual Overview - Doc
</div>
<p class="bigger">
Plain-language <a href="https://docs.bisq.network/user-dao-intro.html" target="_blank">description</a> of the DAO.
Plain-language <a href="https://docs.bisq.network/user-dao-intro.html" target="_blank" rel="noopener">description</a> of the DAO.
</p>
</div>

Expand All @@ -296,7 +296,7 @@ <h2 style="margin: 2em 0;">Want to learn more?</h2>
Technical Overview - Doc
</div>
<p class="bigger">
<a href="https://docs.bisq.network/dao/specification.html" target="_blank">Specification</a> of the workings of the Bisq DAO and BSQ token.
<a href="https://docs.bisq.network/dao/specification.html" target="_blank" rel="noopener">Specification</a> of the workings of the Bisq DAO and BSQ token.
</p>
</div>

Expand Down
4 changes: 2 additions & 2 deletions downloads.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ <h1>Bisq Downloads</h1>
<h5>Bisq Mobile Notifications</h5>
<p>Stay up-to-date on your trades and receive notifications on your mobile phone.</p>

<a target="_blank" href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq"><img class="badge-img mb-2" alt="Get it on Google Play" src="{{ site.url }}/images/badge_google_play.svg"/></a>
<a target="_blank" rel="noopener" href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq"><img class="badge-img mb-2" alt="Get it on Google Play" src="{{ site.url }}/images/badge_google_play.svg"/></a>
&nbsp;
<a target="_blank" href="https://itunes.apple.com/us/app/bisq-mobile/id1424420411"><img class="badge-img mb-2" alt="Get it on the App Store" src="{{ site.url }}/images/badge_app_store.svg"/></a>
<a target="_blank" rel="noopener" href="https://itunes.apple.com/us/app/bisq-mobile/id1424420411"><img class="badge-img mb-2" alt="Get it on the App Store" src="{{ site.url }}/images/badge_app_store.svg"/></a>
<p class="small mt-2">Bisq version <strong>0.8.0</strong> or higher is required to receive mobile notifications.</p>
</div>
Loading