This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Resolve bisq-core by new GAV coordinates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See bisq-network/bisq#1440 for details
This reverts commit afa85a5 as this workaround is no longer required with the changes in the preceding commit. See bisq-network/bisq#1440 for further details.
ManfredKarrer
approved these changes
Mar 9, 2018
cbeams
added a commit
to bisq-network/bisq
that referenced
this pull request
Mar 9, 2018
Problem: d218094 set the version to 0.7.0-SNAPSHOT, but that change failed to produce the intended effect detailed in the commit comment. Setting the version to a value like 0.7.0-SNAPSHOT works fine when publishing artifacts to a local ~/.m2 repository, but JitPack has no awareness of version metadata within pom files, and can only retreive artifacts based on Git metadata, namely tags, branch names and commit hashes. This means it is impossible to resolve artifacts from JitPack with a GAV like `io.bisq.exchange:core:0.7.0-SNAPSHOT` unless there is a branch named `0.7.0`. This is why the pull request at bisq-network/bisq-seednode#1 failed. Solution: JitPack supports the semantics of Maven-style `-SNAPSHOT` versioning, and as a special case, allows for versions to be named literally `-SNAPSHOT` with no preceding version string [1,2]. This commit sets all Maven versions to `-SNAPSHOT`, achieving the original effect intended by d218094. Now downstream components (like bisq-seednode) can resolve dependencies seamlessly from JitPack or a local ~/.m2 repo with a GAV like `io.bisq.exchange:core:-SNAPSHOT`. This is a slightly unconventional arrangement, but should actually result in fewer updates to pom files over time as there may in fact be no reason to ever change this version string so long as we continue using JitPack and avoid publication to Maven Central / JCenter or similar. [1]: https://jitpack.io/docs/#building-with-jitpack [2]: jitpack/jitpack.io#351 See #1440
cbeams
added a commit
that referenced
this pull request
Mar 9, 2018
See bisq-network/bisq@19b9c6fe for details on why this breakage occurred and why this change fixes it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This PR can be merged only after bisq-network/bisq#1440 has been merged.