This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Add proposals.adoc #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doc captures the clarifications and refinements to the proposals process proposed in bisq-network/proposals#11.
blabno
suggested changes
Apr 23, 2018
|
|
||
| Once a proposal is submitted, a two-week review period follows. During this period, interested reviewers should read, discuss and ultimately react to the proposal as follows: | ||
|
|
||
| - 👍: I agree with the proposal and want to see it enacted |
There was a problem hiding this comment.
This renders as square. I think something else was intended here.
There was a problem hiding this comment.
Interesting, looking into it.
There was a problem hiding this comment.
This is what I see in the deploy preview at https://deploy-preview-40--bisq-docs.netlify.com/proposals.html:
Can you share a screenshot of what you see?
blabno
approved these changes
Apr 23, 2018
In response to review feedback.
This reverts commit 0ba1084, because it made no difference on the affected OS (Gentoo Linux). It seems the only way to guarantee that these emoji show up properly everywhere is to use images instead of characters. This is what GitHub does, for example, everywhere they use these symbols.
cbeams
added a commit
to bisq-network/proposals
that referenced
this pull request
Apr 23, 2018
cbeams
added a commit
to bisq-network/proposals
that referenced
this pull request
Apr 23, 2018
This was referenced May 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doc captures the clarifications and refinements to the proposals
process proposed in bisq-network/proposals#11.