Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Test Netlify deploy preview #38

Closed

Conversation

cbeams
Copy link
Contributor

@cbeams cbeams commented Apr 16, 2018

No description provided.

@cbeams cbeams self-assigned this Apr 16, 2018
@cbeams cbeams requested a review from m52go April 16, 2018 20:20
@cbeams
Copy link
Contributor Author

cbeams commented Apr 16, 2018

@m52go, for your work on #37, feel free to open a pull request early in the process, against which you can push and rebase however many commits you like. In doing so, you can get live "deploy previews" via Netlify like the one this PR produced here: https://deploy-preview-38--bisq-network-docs.netlify.com/ Note the THIS IS A TEST text at the bottom of the page, and compare with commit 93f5f7d above.

You'll also see the deploy preview notifications coming into the #bisq-docs channel like those seen at https://bisq.slack.com/archives/C701A4NNS/p1523909554000212.

All of this basically means super-easy collaboration, in the sense that it's possible for everyone to see a live preview of your latest changes without having to build it themselves locally. Just an option that I thought you'd like to know about.

One thing, though, if you open this kind of pull request, is that you should indicated it is not intended to be reviewed and merged right away by prefixing the pull request title with [WIP]. That lets the @bisq-network/docs-maintainers know that they don't need to bother prioritizing a review.

I've assigned you to review this PR—there's nothing to do other than acknowledge that you've seen it / ask any questions, etc. Once you've done so, I'll close it.

@cbeams
Copy link
Contributor Author

cbeams commented Apr 18, 2018

@m52go, I'm closing this to keep things clean, but please do read through this PR when you have a moment.

@cbeams cbeams closed this Apr 18, 2018
@m52go
Copy link
Contributor

m52go commented Apr 18, 2018

Done! Thanks for taking the time to write this out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants