Updating the "How to Seednode" docs #148
Conversation
--myAddress has been removed in bisq-network/bisq#2476
The memory leak topic has been resolved in bisq-network/bisq#2475
systemd support has been added in bisq-network/bisq#2501
8293b68 to
3583ca7
Compare
|
Thanks @freimair, quite a substantial update. I can't give this a fair review, but it looks like you've already gotten feedback from ManfredKarrer. Perhaps @devinbileck or @mrosseel could do a final look-over? |
|
Sure, I will take a look. |
There was a problem hiding this comment.
utACK
Overall this looks good. Just some minor corrections. I am not familiar with the monitoring/collectd so cant comment much on that, but plan to incorporate it with my seeds in the future.
@m52go perhaps you can review for wording/structure?
Co-Authored-By: Devin Bileck <603793+devinbileck@users.noreply.github.com>
Co-Authored-By: Devin Bileck <603793+devinbileck@users.noreply.github.com>
Co-Authored-By: Devin Bileck <603793+devinbileck@users.noreply.github.com>
There was a problem hiding this comment.
@freimair most of my suggestions are minor and offered as 'suggested edits' so you don't have to go back and do them yourself. Feel free to disregard/reject any you don't like.
The introduction is the only part you might have to go back and edit yourself, as it spans multiple lines, and suggested edits only work for single lines.
Looks good to me overall.
Co-Authored-By: Steve Jain <mfiver@gmail.com>
server and txinde and txindex option is only use by json rpc dbcache, maxconnection, timeout are tweaks to be done with respect available resources
|
Cool, thanks @freimair. Let me know when you're ready and I'll merge. |
|
utACK |
Since there have been changes in the Bisq software which have not been reflected in the docs, I took on the liberty to at least improve that.
About half way through, I decided that the whole section needs to be reworked (as I received a couple of questions on how to run a seed node because the docs have been considered incomplete and difficult)
Note that there is still no mentioning of the bitcoinj-part of running a seed node. Maybe someone can jump in since I quit running seed nodes before bitcoinj has become necessary and therefore, have no idea on how to do that.
This PR is done as preparation for an upcoming bisq-network/proposals#102.