Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

Add translations for info icon in market based price input field #38

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Add translations for info icon in market based price input field #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/resources/i18n/displayStrings.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,14 @@ offerbook.warning.tradeLimitNotMatching=Your payment account has been created {0
You cannot take that offer at the moment. Once your account is older than 2 months this restriction gets removed.


offerbook.info.sellAtMarketPrice=You will sell at market price (updated every minute).
offerbook.info.buyAtMarketPrice=You will buy at market price (updated every minute).
offerbook.info.sellBelowMarketPrice=You will get {0} less than the current market price (updated every minute).
offerbook.info.buyAboveMarketPrice=You will pay {0} more than the current market price (updated every minute).
offerbook.info.sellAboveMarketPrice=You will get {0} more than the current market price (updated every minute).
offerbook.info.buyBelowMarketPrice=You will pay {0} less than the current market price (updated every minute).
offerbook.info.buyAtFixedPrice=Your will buy at this fixed price.
offerbook.info.sellAtFixedPrice=You will sell at this fixed price.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ripcurlx, these translations look OK from a native speaker's point of view, but I'm not sure why there is a "sell at / buy at" vs "get / pay" difference. Why not do the following instead?

offerbook.info.sellBelowMarketPrice=You will sell at {0} less than the current market price (updated every minute).
offerbook.info.buyAboveMarketPrice=You will buy at {0} more than the current market price (updated every minute).

I am assuming that the {0} placeholder will be replaced with a percent value, btw. e.g. "You will sell at 2% less than the current market price..."

Copy link
Contributor Author

@ripcurlx ripcurlx Mar 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the placeholder is replaced by the absolute percentage distance.
Regarding buy/sell vs. get/pay: I wasn't sure if it might be easier for the user to understand if I use get/pay in some cases instead of buy/sell e.g.

offerbook.info.sellAboveMarketPrice=You will get 2% more than the current market price (updated every minute).

instead of

offerbook.info.sellAboveMarketPrice=You will sell at 2% more than the current market price (updated every minute).

But it's just a personal feeling (and I'm no native speaker)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd favor being consistent. I don't think this is really about native-speaker nuance here, just the general principle that it's better to say the same thing one way versus two ways.

I might make the same point about using the phrase "above the current market price" vs. "more than the current market price", but I don't feel super strongly about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also a big fan of consistency, but based on some comments on different issues, I have the feeling that it always takes a lot of thinking to understand if above/below in combination with buy/sell is good or bad for me. I think I should start to do more user testing soon to get a better feeling on the biggest pain points within the upcoming release.


####################################################################
# Offerbook / Create offer
Expand Down
8 changes: 8 additions & 0 deletions src/main/resources/i18n/displayStrings_de.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,14 @@ offerbook.warning.currencyBanned=Die in diesem Handel verwendete Währung wurde
offerbook.warning.paymentMethodBanned=Die in diesem Handel verwendete Zahlungsmethode wurde von den Bisq-Entwicklern blockiert.\nBitte besuchen sie das Bisq-Forum für weitere Informationen.
offerbook.warning.nodeBlocked=Die Onion-Adresse dieses Händlers wurde von den Bisq-Entwicklern blockiert.\nWahrscheinlich gibt es einen unbehobenen Bug, der Probleme beim Annehmen von Angeboten dieses Händlers verursacht.

offerbook.info.sellAtMarketPrice=Sie verkaufen zum aktuellen Marktpreis (wird jede Minute aktualisiert).
offerbook.info.buyAtMarketPrice=Sie kaufen zum aktuellen Marktpreis (wird jede Minute aktualisiert).
offerbook.info.sellBelowMarketPrice=Sie bekommen {0} weniger verglichen zum aktuellen Marktpreis (wird jede Minute aktualisiert).
offerbook.info.buyAboveMarketPrice=Sie zahlen {0} mehr verglichen zum aktuellen Marktpreis (wird jede Minute aktualisiert).
offerbook.info.sellAboveMarketPrice=Sie bekommen {0} mehr verglichen zum aktuellen Marktpreis (wird jede Minute aktualisiert).
offerbook.info.buyBelowMarketPrice=Sie zahlen {0} weniger verglichen zum aktuellen Marktpreis (wird jede Minute aktualisiert).
offerbook.info.buyAtFixedPrice=Sie kaufen zu diesem Festpreis.
offerbook.info.sellAtFixedPrice=Sie verkaufen zu diesem Festpreis.

####################################################################
# Offerbook / Create offer
Expand Down