Fix: hidden files/directories were not included #15
Conversation
Files and directories in the template starting with . were not included anymore after this change: #14
| @@ -13,8 +13,8 @@ import ( | |||
| "text/template" | |||
| ) | |||
|
|
|||
| //go:embed templates/* | |||
| var templates embed.FS | |||
| //go:embed templates/basic/* | |||
There was a problem hiding this comment.
When you're embedding a directory tree with go:embed, entries starting with a . are ignored unless they're named explicitly. The * includes entries starting with a . so that also counts as naming them explicitly.
There was a problem hiding this comment.
It looks like the motivation for implementing it this way was to avoid the .DS_Store files that Mac OS tends to litter its filesystem with: golang/go#42328
Thanks, Apple!
There was a problem hiding this comment.
auheuaheaueh I remember this because I had some issues with dotfiles not being embedded here, but I did miss it on the review, sorry (I dont remember it that well...I just think I was bitten by this more than once 😆 ).
Fucking Bradley/Apple !!!
There was a problem hiding this comment.
It also ignores underscore...didn't remember that 😆
"all the files to embed will ignore names beginning with dot or underscore, the same as the go command does
for deciding what to build."
why the fuck underscore ?
There was a problem hiding this comment.
Not sure, maybe some editors create temporary files with names starting with underscore?
Files and directories in the template starting with . were not included anymore after this change:
#14