fix(core): fix workspace scanner in LSP #5286
Merged
+60
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siketyan
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out the issue with the scanner in the LSP was just a footgun I ran into with Tokio: I was passing an
asyncscan function totokio::spawn_blocking(), which ended up doing... nothing, because nobody awaits the returnedFuture.With that fixed, I immediately discovered that our LSP triggers 4 calls to the scanner because of some config updates it tries to process, so I implemented the functionality to not always rescan folders that are already being watched.
Test Plan
Tests are updated and should remain green. Manually tested too.