Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to Rustfmt 2024 style edition #5236

Merged
merged 4 commits into from
Mar 2, 2025
Merged

chore: switch to Rustfmt 2024 style edition #5236

merged 4 commits into from
Mar 2, 2025
+9,969 −2,511

Conversation

siketyan
Copy link
Member

@siketyan siketyan commented Mar 2, 2025 •
edited
Loading

Summary

Follow-up of #5224

Removed style_edition = "2021" from rustfmt.toml and run cargo fmt.

TODO(siketyan): After merging this, add the commit hash to .git-blame-ignore-revs See #5238

Test Plan

Existing CIs should be green.

@siketyan siketyan requested review from a team March 2, 2025 10:26
@siketyan siketyan self-assigned this Mar 2, 2025
@siketyan siketyan marked this pull request as ready for review March 2, 2025 10:26
@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis L-HTML Language: HTML L-Grit Language: GritQL labels Mar 2, 2025
@siketyan siketyan changed the title style: switch to Rustfmt 2024 style edition chore: switch to Rustfmt 2024 style edition Mar 2, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5236 will not alter performance

Comparing style/rustfmt-2024 (ea66cce) with main (bf675cf)

Summary

✅ 97 untouched benchmarks

@siketyan siketyan merged commit 9b2d5db into main Mar 2, 2025
12 checks passed
@siketyan siketyan deleted the style/rustfmt-2024 branch March 2, 2025 11:33
siketyan added a commit to siketyan/biome that referenced this pull request Mar 2, 2025
@siketyan
chore: add biomejs#5236 to .git-blame-ignore-revs
d45a2fe
@siketyan siketyan mentioned this pull request Mar 2, 2025
Merged
ematipico pushed a commit that referenced this pull request Mar 2, 2025
@siketyan
chore: add #5236 to .git-blame-ignore-revs (#5238)
bd05a4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

@siketyan siketyan

Labels
A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-Grit Language: GritQL L-HTML Language: HTML L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siketyan @ematipico