fix: add missing use<> to RPIT's
#5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43ba80f to
785fabe
Compare
CodSpeed Performance ReportMerging #5222 will not alter performanceComparing Summary
|
ematipico
approved these changes
Mar 1, 2025
785fabe to
ad52204
Compare
arendjr
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #5196
In Rust 2024 edition, we need to add
use<>notation to control which lifetime is captured in RPIT's (return-position impl Trait). This pull request adds these notations based on theimpl_trait_overcaptureslint rule, before upgrading to 2024.ref: https://doc.rust-lang.org/edition-guide/rust-2024/rpit-lifetime-capture.html
Test Plan
Existing tests should pass.