Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explain command for rule #5214

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix: explain command for rule #5214

merged 1 commit into from
Feb 28, 2025

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Feb 28, 2025

Summary

This PR fixes a small bug in the explain command. Changeset not needed because this new version isn't released yet.

Test Plan

Snapshot updated

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter labels Feb 28, 2025
@@ -85,7 +85,7 @@ impl biome_console::fmt::Display for RuleMetadata {

if self.domains.is_empty() && self.recommended {
fmt.write_markup(markup! {
"- This rule is not recommended"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😺

Copy link

codspeed-hq bot commented Feb 28, 2025

CodSpeed Performance Report

Merging #5214 will not alter performance

Comparing fix/explain-rule (86772a0) with main (d95df40)

Summary

✅ 97 untouched benchmarks

@ematipico ematipico merged commit 155b6a3 into main Feb 28, 2025
14 checks passed
@ematipico ematipico deleted the fix/explain-rule branch February 28, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Linter Area: linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants