feat(lsp): allow overriding the configuration path from LSP workspaces #5093
Conversation
| @@ -492,6 +492,20 @@ impl Session { | |||
| if let Some(config_path) = &self.config_path { | |||
| let base_path = ConfigurationPathHint::FromUser(config_path.clone()); | |||
| let status = self.load_biome_configuration_file(base_path).await; | |||
| self.set_configuration_status(status); | |||
| } else if let Some(config_path) = self | |||
There was a problem hiding this comment.
We need to consider how to migrate users (LSP clients) smoothly for this change. For example, biome-intellij currently using --config-path for overriding the config path. To prefer this new option on the plugin, we need to check the Biome version is >= 2.0. This requires some additional work for plugin side and not a smooth path.
Maybe should we prefer this new option over the existing --config-path flag? If so, we can just put the config path to both the CLI flag and the LSP request to support Biome < 2 and >= 2.
There was a problem hiding this comment.
Since we are about to do a v2 release, I believe this is the right time to remove stuff. I know that users would prefer to have a deprecation warning, but I wouldn't want to carry --config-path until we hit v3.
I believe this is the right time to have core and editor extensions to do the breaking change. VSCode extension has already removed it. We should do the same for IntelliJ and Zed.
If we remove --config-path from lsp-proxy, the CLI won't even start.
There was a problem hiding this comment.
Agree. I will rebase this branch and remove --config-path option. Later, I will also remove from biome-intellij, and find a chance for Zed.
There was a problem hiding this comment.
I will remove --config-path in a separated PR.
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
37448c5 to
37de5b7
Compare
Summary
As the first step of #5089, this pull request adds a new option
experimental.configurationPathto the response ofworkspace/configurationrequest. It will affect when loading workspace configurations, preferred over the defaultbiome.jsonin the workspace.Test Plan
Existing tests should pass.
For the new option, I tested my modified build of biome-intellij with
workspace/configurationsupport added. I could confirm that two projects work in parallel with different Biome configurations.