fix(format/html): make element children break if attributes break #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
commented
Feb 3, 2025
Comment on lines
135
to
144
| [ | ||
| // If the attribute group breaks, prettier always breaks the children as well. | ||
| &if_group_breaks(&expanded_children).with_group_id(Some(attr_group_id)), | ||
| // Otherwise, we can do whatever fits best for the children. | ||
| &if_group_fits_on_line(&best_fitting![ | ||
| format_args![flat_children], | ||
| format_args![expanded_children] | ||
| ]) | ||
| .with_group_id(Some(attr_group_id)) | ||
| ] |
There was a problem hiding this comment.
I can't seem to figure out why this sometimes doesn't emit content. The ordering of these lines also appears to change the outcome.
There was a problem hiding this comment.
I've pushed a somewhat hacky workaround for this bug in 6e4b40e.
CodSpeed Performance ReportMerging #5027 will not alter performanceComparing Summary
|
1c79995 to
a90247b
Compare
ematipico
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #5026
Test Plan
Added a snapshot test, and none of the other tests are affected.